New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use content-disposition header for file names #315

Merged

FrankApiyo merged 4 commits into master from use-content-disposition-header-for-xls-file-extensions

Feb 24, 2023

Member

FrankApiyo commented Feb 22, 2023 •

edited

Loading

Todo

Add tests

FrankApiyo added 2 commits

February 22, 2023 12:45


          Use content-disposition header for file names

fcd4f25


          Bump milia to 0.9.0-rc

FrankApiyo requested review from ciremusyoka, JohnMwashuma and KipSigei

February 23, 2023 07:10


          Add test cases to check that .xlsx files are renamed correctly

070faad

FrankApiyo force-pushed the use-content-disposition-header-for-xls-file-extensions branch from e4c64f3 to 070faad Compare

February 23, 2023 07:12

KipSigei approved these changes

View reviewed changes


          Bump milia to 0.9.1-rc

5f1d576

FrankApiyo merged commit aade5d5 into master

FrankApiyo deleted the use-content-disposition-header-for-xls-file-extensions branch

February 24, 2023 09:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet