Exports with label choices test. #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincmba
force-pushed
the
1483-fix-export-with-label-choices
branch
from
b6a6944
to
cf26719
Compare
…used instead of names when this parameter is set to true. Signed-off-by: Lincoln Simba <lincolncmba@gmail.com>
Signed-off-by: Lincoln Simba <lincolncmba@gmail.com>
lincmba
force-pushed
the
1483-fix-export-with-label-choices
branch
from
a94da5d
to
17d23f6
Compare
ukanga
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was supposed to address #1483. But it was fixed on pyxform side by this .
This has an additional test for show_choice_labels=true in exports. Labels to be used in the exports instead of names when this parameter is set to true.
Fixes #1483
Signed-off-by: Lincoln Simba lincolncmba@gmail.com