Data endpoint enhancements #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
2472-data-api-limitations
branch
from
f545f32
to
11ff0c4
Compare
add endpoint force json update for all submissions under current form
refactor the /api/v1/forms/<form_id>/regenerate-submission-metadata endpoint to only trigger async task if task has failed or does not exist in cache
…ting when sort query parameter is applied with pagination, the pagination link header was missing
add documentation for endpoint /api/v1/forms/{pk}/regenerate-submission-metadata
fix error pycodestyle: E501 / line too long (90 > 88 characters) (col 89)
fix unused argument self
there is already a json field present that already has the result the getter is recalculating
kelvin-muchiri
force-pushed
the
2472-data-api-limitations
branch
from
b5d13a2
to
2117f08
Compare
json is set in the post_save signal so setting it explicitly is unnecessary
kelvin-muchiri
requested review from
KipSigei,
FrankApiyo,
ukanga and
ciremusyoka
KipSigei
suggested changes
Sep 27, 2023
ukanga
requested changes
Sep 27, 2023
bug appears when pagination is used with sort and query query paramaters
…ta into command convert endpoint into Django custom command
ensure we do not regenerate instance json if instance json has already been regenerated
consider-using-f-string / Formatting a regular string which could be a f-string
address raise-missing-from, consider-using-f-string update docstring
KipSigei
approved these changes
Sep 28, 2023
ukanga
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
/api/v1/data/<form_id>when sort query parameter is applied with paginationonadata/apps/logger/models/migrations/001_pre-django-3-upgrade.pypreventing newer migrations for model XForm from being applied. This issue tracks this bug.Steps taken to verify this change does what is intended
Side effects of implementing this change
No side effects
Before submitting this PR for review, please make sure you have:
Closes #2472 #2480