Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external links and internal routes #13

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add external links and internal routes #13

merged 2 commits into from
Feb 2, 2024

Conversation

akanuri9
Copy link
Contributor

@akanuri9 akanuri9 commented Feb 1, 2024

@akanuri9 akanuri9 requested a review from drbgfc February 1, 2024 22:01
drbgfc
drbgfc reviewed Feb 2, 2024
View reviewed changes
src/components/shared/nav/nav/categories/SiteNavIndustryTools.tsx Outdated
isExternalLink: true,
href: GENERIC_LINK_TO_REPLACE,
isExternalLink: false,
href: 'reference-data',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing slash

drbgfc
drbgfc reviewed Feb 2, 2024
View reviewed changes
src/components/shared/nav/nav/categories/SiteNavIndustryTools.tsx Outdated
isExternalLink: true,
href: GENERIC_LINK_TO_REPLACE,
isExternalLink: false,
href: 'implementation-guide-authoring-tools',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs slash prefix

drbgfc
drbgfc reviewed Feb 2, 2024
View reviewed changes
public/alternative-test-methods/tempFileForStructure-deleteWhenFilesAdded Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

drbgfc
drbgfc approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@drbgfc drbgfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Added the slashes, merging

@drbgfc drbgfc changed the title Add External Links and Internal Home Pages Add external links and internal routes Feb 2, 2024
@drbgfc drbgfc merged commit 3e7cd13 into dev Feb 2, 2024
@drbgfc drbgfc deleted the SITE-3877 branch February 2, 2024 03:41
@akanuri9
Copy link
Contributor Author

akanuri9 commented Feb 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbgfc drbgfc drbgfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akanuri9 @drbgfc