Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site 3986 #67

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Site 3986 #67

merged 4 commits into from
Jun 7, 2024

Conversation

ebrockainq
Copy link
Contributor

No description provided.

src/components/direct/hisp/TestCard.tsx Outdated Show resolved Hide resolved
p: 2,
}}
>
{test.ccdaFileRequired && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all other buttons removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also a mistake, I will correct it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be dynamic to be used with all test cases

@@ -101,20 +105,32 @@ const testCases = {
desc: "Verifies the ability of the receiving system to correctly timeout for various SMTP commands. The tool will keep the transaction open until a timeout is noted. As there are no required time limits in RFC 2821 section 4.5.3.2, this test is configurable. Hitting 'Run' will begin the ETT's timer based on the value in seconds entered below. The default entry, 0, allows a maximum time-out (no limit). Enter a value greater than your systems time-out period to perform this test.",
longDesc:
"The objective of this test sequence is to determine if an Edge System (e.g., SUT), acting as the receiver, can successfully establish an active session with a HISP (e.g., ETT), acting as the sender, and conform to the specific timeout requirements within the RFC and SMTP command.\n The details for conformance testing flow are as follows: The ETT will initiate a connected session with the SUT. The SUT will attempt to keep a transaction open with the ETT for beyond the specified time constraints found within RFC 2821, Section 4.5.3.2. \nThis is required test and maintains compliance with the secure health data transport messaging formats, processing requirements, and communication standards for Direct Edge message exchanges. See Section 1.2.1 and 1.2.2 of the 'Implementation Guide for Direct Edge Protocols' document. ",
moreInfo: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here in these files are more static content based of https://github.com/onc-healthit/ett/blob/f766d1f20ba56c4f1167f22a8df4bfafaff830bf/gui/src/assets/xdrtestCases.json and I think it should be considered as data file, I am note sure having imports into this file makes sense. Instead you can dynamically show the icons based on the data. I think it will be difficult for maintenance.

Copy link
Contributor Author

@ebrockainq ebrockainq Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what you mean, I'll try to find a solution to this

Replaced missing buttons

Replaced missing fields

Removed imports from data files
Copy link
Contributor

@akanuri9 akanuri9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i believe this is going to change a bit when we get to functionality.

I see that the build check has failed, please correct the errors.

@akanuri9 akanuri9 merged commit b763432 into dev Jun 7, 2024
2 checks passed
ebrockainq added a commit that referenced this pull request Jul 30, 2024
* Test Card More Info Page

* XDR Test Card More Info Page

* Corrections from PR 67

Replaced missing buttons

Replaced missing fields

Removed imports from data files

* Fix build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants