Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new disk #32

Merged
merged 30 commits into from
Sep 22, 2022
Merged

Create new disk #32

merged 30 commits into from
Sep 22, 2022

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Aug 31, 2022

Description

This change allows Discoblock to create new disk if lastly created has reached the treshold.

Fixes # #26

Type of change

Please check options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • CRD availability mode names has been changed
  • This change requires a documentation update

How Has This Been Tested?

Manually, automation tests are missing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mhmxs mhmxs added the invalid This doesn't seem right label Aug 31, 2022
@mhmxs mhmxs removed the invalid This doesn't seem right label Sep 13, 2022
@mhmxs mhmxs merged commit 7b72c8d into main Sep 22, 2022
@mhmxs mhmxs deleted the create-new-disk branch September 22, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants