Skip to content

Conversation

kampfschlaefer
Copy link
Contributor

regardless whether the repository is freshly created or not.

regardless whether the repository is freshly created or not.
@zuazo
Copy link
Owner

zuazo commented Nov 8, 2014

It seems that this breaks why-run support, doesn't it?

@kampfschlaefer
Copy link
Contributor Author

Probably.

I have to admit that I have to read up on why-run...

@kampfschlaefer
Copy link
Contributor Author

No, it shouldn't break why-run as far as I see it as the cookbook_file resource supports why-run already. It will show up as another dynamically defined resource though.

When argumenting small resources, a point could be made to create a new resource/provider for the post-update-hook. And for adding more custom hooks.

@zuazo
Copy link
Owner

zuazo commented Nov 8, 2014

What I mean is that in case the hook is updated, it will not mark the resource as updated because it's outside the converge_by. But maybe this is the desired behavior. I have doubts.

@kampfschlaefer
Copy link
Contributor Author

Well, the desired behaviour is to create the hook even if the repository is already there. So it should be outside the unless-block. I will try something else.

@zuazo
Copy link
Owner

zuazo commented Nov 8, 2014

Yes, but if the hook is updated but not the bare repository, should the git_ssh_server_bare resource fire the notifications (the notifies)? If the answer is yes, the hook code should go inside another converge_by block.

@kampfschlaefer
Copy link
Contributor Author

The resource and action is to create a repository, I think its okay not to fire the notifications when the hooks change.

@zuazo
Copy link
Owner

zuazo commented Nov 8, 2014

OK. Sounds good. Thanks for another PR 😉

zuazo added a commit that referenced this pull request Nov 8, 2014
…ivated

Activate the post-update hook when the param is true
@zuazo zuazo merged commit 280c612 into zuazo:master Nov 8, 2014
@kampfschlaefer kampfschlaefer deleted the create_update_hook_when_activated branch November 9, 2014 00:14
@zuazo
Copy link
Owner

zuazo commented Nov 16, 2014

Released in 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants