Correct develop flow #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Release ONDEWO NLU Python Client 2.6.0 ### New features * [[OND211-1959]](https://ondewo.atlassian.net/browse/OND211-1959) - Intents. GetAllTags and GetAllIntentTags endpoints. ### Improvements * [[OND211-1927]](https://ondewo.atlassian.net/browse/OND211-1927) - Intents. Remove old Intent classification algorithms * [[OND211-1928]](https://ondewo.atlassian.net/browse/OND211-1928) - Entities. Remove old Entity Recognition algorithms
gaborod16
requested review from
teddius,
kNalj,
MohamedYaman and
foldvaridominic
|
It doesn't look like much, but this is actually aligning the Git History so new additions to the |
teddius
requested changes
Jun 21, 2022
foldvaridominic
approved these changes
Jun 21, 2022
|
@teddius please read the code again. The variable |
kNalj
reviewed
Jun 21, 2022
| @@ -26,7 +26,7 @@ def get_all_entities(parent: str, language_code: str, client: Client) -> Dict[st | |||
|
|
|||
| for et in tqdm.tqdm(iterable=response.entity_types, desc='Loading entity map...'): | |||
| for ev in et.entities: | |||
| _map[et.name][ev.name] = _map[et.name][ev.name].union({s for s in ev.synonyms}) | |||
| _map[et.name][ev.name] |= {s for s in ev.synonyms} # Merge sets together in place | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align releases into develop.