Redesing - inspired by Lt-Mayonesa's material design #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loro2
commented
Aug 5, 2019
| @@ -230,23 +231,24 @@ SQL.Row.prototype.load = function() { /* put data to expanded form */ | |||
| SQL.Row.prototype.redraw = function() { | |||
| var color = this.getColor(); | |||
| this.dom.container.style.backgroundColor = color; | |||
| this.dom.container.style.borderColor = color; | |||
There was a problem hiding this comment.
This is the only functional change in this file. Sorry about the styling changes, I missed reverting them in this file.
|
Hello, I'd like to ping this PR. I understand this project is not high priority now, so this is just a friendly reminder of this PR if it got forgotten about unwillingly. The change to legacy code is quite trivial and there is a single new .css file. Thanks. |
|
Hi, ping received. I just returned from a 3-week vacation. Please give me some time to review the code. I am totally willing to merge this, so checking the code is basically only a formality. |
|
@loro2 , thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a simple redesign (#252) with support for switching between the new and original styles (in options, via css switching). The design work was basically done by Lt-Mayonesa in #254, but I implemented it in a more simplistic fashion, touching the html and javascript code as little as possible. The layout resembles the original, with the color scheme and some design cues taken from Lt-Mayonesa's work. I didn't use the mui framework, only vanilla css.
I think the whole #254 redesign can be implemented in this manner by building further upon this PR in the future.