Fix patch version when running CMake outside the source tree #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determination of patch version fails when running CMake outside the source tree. For example, this currently fails to determine the patch version: $ git clone https://github.com/oneapi-src/level-zero.git $ cmake -B build -S level-zero $ make -C build To fix this, we must ensure that the git command runs in the ${CMAKE_SOURCE_DIR} directory. This can be done by specifying the source tree with the git '-C' option.
ghost
reviewed
Mar 23, 2020
|
We recently pushed 1403f9f which should resolve this issue. If it does, you can close this pull request. |
|
Yes, commit 1403f9f fixed this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determination of patch version fails when running CMake outside the source tree.
For example, this currently fails to determine the patch version:
To fix this, we must ensure that the
gitcommand runs in the${CMAKE_SOURCE_DIR}directory. This can be done by specifying the source tree with the git-Coption.