-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security md #2798
Update security md #2798
Conversation
@bdmoore1 can you review and approve this please? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all of the asterisks after Library. The asterisk is to signify a 3rd party brand name. Scikit-learn is a 3rd party brand name, so that's why it was there before. But oneDAL is Intel's brand name so we brand it with (R) and (TM).
SECURITY.md
Outdated
* You need help applying security-related updates. | ||
* Your issue is not security-related. | ||
|
||
## Security Reports Review Process | ||
|
||
We aim to respond quickly to your inquiry and coordinate a fix and | ||
disclosure with you. All confirmed security vulnerabilities will be addressed | ||
according to severity level and impact on Intel(R) Extension for Scikit-learn*. Normally, security issues | ||
are fixed in the next planned release. | ||
according to severity level and impact on Intel(R) oneAPI Data Analytics Library*. Normally, security issues are fixed in the next planned release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the asterisk after Library (*)
I'll approve the PR once Ben's comments are addressed. |
Update SECURITY.md removed asterix
a847d9e
to
288fb13
Compare
Hi @maria-Petrova I have removed the asterisk and have resolved Bens Comments :) |
Hi @maria-Petrova @emmwalsh , I noticed you've made updates to security.md, which is good. I see a few issues/typos:
|
|
It's up to you. I'd suggest to keep it independent like simply "oneDAL". |
Hi @rozhukov I have made the changes now but for the third point, do you know what the correct link is or should I just remove the link and not replace it with anything? Thanks! |
just link is broken itself in the markdown It should lead to the respective "Report vulnerability" button: https://github.com/oneapi-src/oneDAL/security/advisories/new |
Hi @rozhukov, thanks so much for that! I have updated the second link now. For the third link under the disclosure policy, do you know what the link should be for [GitHub Security Advisories feature][3]? Thanks! |
sure, no problem. It'd be: https://github.com/oneapi-src/oneDAL/security/advisories |
Updated SECURITY.md file as requested by Nikolay Petrov