Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of dr::shp::sort() #1614

Merged
merged 20 commits into from
Jun 25, 2024

Conversation

lslusarczyk
Copy link
Contributor

@lslusarczyk
Copy link
Contributor Author

@mateuszpn ,

  1. format test is failing, both in this PR and in your update of dr::shp::sort() #1608 - please make it passing. But do it automatically, not manually. Look at oneDPL CI what command do they invoke to check format and invoke the same or similar one to fix the format of your change.
  2. you have added dr namespace where it is not needed, e.g. changed distributed_range into dr::distributed_range. Please revert. Don't use namespace if you are already in this namespace. (dr::ranges::rang -> ranges::rank, dr::shp::__detail::local -> __detail::local). Shorter code increases readability.
  3. Don't use internal bug tracker IDs like [GSD-3893] in oneDPL
  4. ONEDPL_USE_DISTRIBUTED_RANGES is not used in the code - remove from cmake.
  5. Is -ftemplate-backtrace-limit=0 really needed by this change. I don't think so because it was not needed before your change and the change does not add more templates.

mateuszpn and others added 13 commits June 6, 2024 17:31
Signed-off-by: Benito, Dylan <dylan.benito@intel.com>
* Update release_notes.rst

* Fixed wordings and removed fixed issue from known issues list

* Add one more new feature

* Add one more new feature

* Add missing word

* Apply suggestions from code review

Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>

* Update release_notes.rst

* Update documentation/release_notes.rst

Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>

* Update documentation/release_notes.rst

Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>

* Tiny reformatting

---------

Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
@lslusarczyk lslusarczyk merged commit 7a0673b into oneapi-src:distributed-ranges Jun 25, 2024
20 of 21 checks passed
@lslusarczyk lslusarczyk deleted the sort_merge branch June 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants