Remove non standard function calls, and use qualified name for half #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbalint98
changed the title
|
@sbalint98 Thanks for the PR. Could you please split this into two separate PRs? One for .what() and other for type qualification changes? |
|
sure, closing this and opening two new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the
get_cl_code()calls that are not part of the SYCL standard with the standardized.what()function calls. furthermore, it adds qualification for the half and other types where necessary. This PR as described in #99 necessary for adding support for using hipSYCL with oneMKL.Checklist
All Submissions