Feat/basetypes #11
Closed
Feat/basetypes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated |
CesarD
requested changes
Jan 10, 2023
| @@ -23,6 +23,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\Monaco.Template.Common.Domain\Monaco.Template.Common.Domain.csproj" /> | |||
There was a problem hiding this comment.
You don't need this reference because it already exists by transitivity because of Monaco.Template.Common.Infrastructure.
Suggested change
| <ProjectReference Include="..\Monaco.Template.Common.Domain\Monaco.Template.Common.Domain.csproj" /> |
src/Content/Monaco.Template.Common.Application/DTOs/Extensions/BaseTypeExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,30 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
This file and its path have an extra space in Common. Application.Tests.
Please fix the typo.
| @@ -64,6 +64,8 @@ EndProject | |||
| #if (filesSupport) | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Monaco.Template.Common.BlobStorage", "Monaco.Template.Common.BlobStorage\Monaco.Template.Common.BlobStorage.csproj", "{42E51D47-B82F-4A92-B1E5-CD8BE44DE6F0}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Monaco.Template.Common. Application.Tests", "Monaco.Template.Common. Application.Tests\Monaco.Template.Common. Application.Tests.csproj", "{93ECBA58-111C-401F-AA51-45626772E14A}" | |||
There was a problem hiding this comment.
Please fix the typo once the path has been corrected at file system.
Suggested change
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Monaco.Template.Common. Application.Tests", "Monaco.Template.Common. Application.Tests\Monaco.Template.Common. Application.Tests.csproj", "{93ECBA58-111C-401F-AA51-45626772E14A}" | |
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Monaco.Template.Common.Application.Tests", "Monaco.Template.Common.Application.Tests\Monaco.Template.Common.Application.Tests.csproj", "{93ECBA58-111C-401F-AA51-45626772E14A}" |
| using Monaco.Template.Common.Application.DTOs.Extensions; | ||
| using Monaco.Template.Common.Domain.Model; | ||
|
|
||
| namespace Monaco.Template.Common._Application.Tests; |
There was a problem hiding this comment.
Suggested change
| namespace Monaco.Template.Common._Application.Tests; | |
| namespace Monaco.Template.Common.Application.Tests; |
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> | ||
| <RootNamespace>Monaco.Template.Common._Application.Tests</RootNamespace> |
There was a problem hiding this comment.
Suggested change
| <RootNamespace>Monaco.Template.Common._Application.Tests</RootNamespace> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work better with Enumeration types and DTOs I've added a class to better with and not repeat code.