FEAT: Replaced System.Drawing implementation. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonzo345
approved these changes
Dec 29, 2022
9 tasks
CesarD
pushed a commit
that referenced
this pull request
Mar 9, 2023
## Description - Refactor FileService to remove remaining dependency on System.Drawing - Fix BlobStorageService GetFileType() to use string.ToLower() - Add unit tests for GetFileType() - Add unit tests to FileServiceTests - Remove duplicate Trait declarations in test classes - General tidy up - Update packages ## Motivation and Context #31 replaced System.Drawing implementation, however FileService still had a dependency on System.Drawing for its Size class. As we are not using any specific functionality from the Size class and are just using it to represent data then we can replace it with a tuple. Other changes in this PR are to: - fix a bug with the GetFileType method that was not handling strings with uppercase characters properly. - correct some typos and apply consistent style in some areas - add unit tests ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **CONTRIBUTING** document. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
Implements
SkiaSharpto replaceSystem.Drawingpackage for resizing images and obtain thumbnails. It also implementsExifLibNetto obtain metadata from images such as Date Taken and GPS Latitude/Longitude.This should allow better cross-OS implementation of the solution.
Added GPS Latitude/Longitude to the
Imageentity sample.