Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Can't properly filter by nullable primitive datatypes #41

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

CesarD
Copy link
Collaborator

@CesarD CesarD commented Mar 3, 2023

Description

Fixed #39 by adding validations that include nullable types and also evaluates the underlying type of an eventually nullable value.
It also fixes another scenario where when comparing non-nullable types against a null value it threw an exception.

Related Issue

Fixes #39

Motivation and Context

Fixes a reported bug.

How Has This Been Tested?

Tested different scenarios via Postman directly against the API.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… against a null value threw an exception.
@CesarD CesarD added the bug Something isn't working label Mar 3, 2023
@CesarD CesarD requested a review from Gonzo345 March 3, 2023 10:51
@CesarD
Copy link
Collaborator Author

CesarD commented Mar 3, 2023

@matthewtoghill please have a look at this PR you too if you like 😉

@CesarD CesarD requested a review from a team March 3, 2023 11:43
Copy link
Collaborator

@Gonzo345 Gonzo345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much to @matthewtoghill and @CesarD for this! (づ ̄3 ̄)づ╭❤️~

@Gonzo345 Gonzo345 merged commit 65dbdd9 into main Mar 7, 2023
@Gonzo345 Gonzo345 deleted the fix/nullable_datatypes_filtering branch March 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't properly filter by nullable primitive datatypes
2 participants