Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: CommandResult simplification and optimization #74

Merged
merged 1 commit into from
Jun 19, 2024
Merged

REFACTOR: CommandResult simplification and optimization #74

merged 1 commit into from
Jun 19, 2024

Conversation

CesarD
Copy link
Collaborator

@CesarD CesarD commented Jun 18, 2024

Description

Closes #73

How Has This Been Tested?

All current tests pass correctly and all affected endpoints have been tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Ture2
Ture2 reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Ture2 Ture2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

...n/Monaco.Template.Backend.Common.Application/Commands/Behaviors/CommandValidationBehavior.cs Show resolved Hide resolved
@Ture2
Copy link
Collaborator

Ture2 commented Jun 19, 2024

Everything clear

@Ture2 Ture2 closed this Jun 19, 2024
@Ture2 Ture2 reopened this Jun 19, 2024
@Ture2 Ture2 merged commit 1c3438c into main Jun 19, 2024
@Ture2 Ture2 deleted the refactor/command_result branch June 19, 2024 14:16
albertpardobadia
albertpardobadia reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@albertpardobadia albertpardobadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ;)

@albertpardobadia
Copy link
Collaborator

Didn't saw it was already merged 🤣 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertpardobadia albertpardobadia albertpardobadia left review comments

@Ture2 Ture2 Ture2 approved these changes

@matthewtoghill matthewtoghill Awaiting requested review from matthewtoghill

@Gonzo345 Gonzo345 Awaiting requested review from Gonzo345

@marcelomusza marcelomusza Awaiting requested review from marcelomusza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REFACTOR: CommandResult simplification and optimization
3 participants
@CesarD @Ture2 @albertpardobadia