REFACTOR: Replace Dawn.Guard with Throw and refactor domain validations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CesarD
requested review from
Gonzo345,
marcelomusza,
Ture2,
matthewtoghill and
albertpardobadia
matthewtoghill
previously approved these changes
Aug 6, 2024
src/Content/Backend/Solution/Monaco.Template.Backend.Common.Domain.Tests/ValueObjectTests.cs
Outdated
Show resolved
Hide resolved
src/Content/Backend/Solution/Monaco.Template.Backend.Common.Domain.Tests/ValueObjectTests.cs
Show resolved
Hide resolved
...on/Monaco.Template.Backend.Application.Tests/Features/Product/CreateProductValidatorTests.cs
Outdated
Show resolved
Hide resolved
.../Backend/Solution/Monaco.Template.Backend.Domain.Tests/Factories/Entities/DocumentFactory.cs
Outdated
Show resolved
Hide resolved
.../Backend/Solution/Monaco.Template.Backend.Domain.Tests/Factories/Entities/DocumentFactory.cs
Show resolved
Hide resolved
...Content/Backend/Solution/Monaco.Template.Backend.Domain.Tests/Factories/FixtureExtensions.cs
Show resolved
Hide resolved
REFACTOR: Added some more tests.
src/Content/Backend/Solution/Monaco.Template.Backend.Domain.Tests/FileTests.cs
Outdated
Show resolved
Hide resolved
...tent/Backend/Solution/Monaco.Template.Backend.Domain.Tests/Factories/Entities/FileFactory.cs
Outdated
Show resolved
Hide resolved
matthewtoghill
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace argument validation library Dawn.Guard with Throw library. Refactor corresponding domain validations and use the occasion to improve them.
Also refactor Handler and Validation classes to make them internal to hide them from public exposure.
Related Issue
Resolves #79
How Has This Been Tested?
Unit tests have been refactored and expanded to cover more cases than before.
Types of changes
Checklist: