Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kernel argument to disable predictable NIC naming. Fixes VIP #1310

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

wouterbouvy
Copy link
Contributor

Tested my yesterdays PR on virtualised cluster and noticed the VIP didn't come up due to Predictable NIC naming being enabled. Fixed by patching install which persists upgrades/install. See here

@github-actions github-actions bot added the area/bootstrap Changes made in the bootstrap directory label Feb 11, 2024
@wouterbouvy
Copy link
Contributor Author

wouterbouvy commented Feb 11, 2024

Made some more changes which simplifies the jinja template by using general patches which are applied to both controllers and workers removing the need to use YAML anchors.

I also removed the KubePrism patch as it's enabled by default from Talos 1.6

@onedr0p onedr0p merged commit 6c637aa into onedr0p:main Feb 11, 2024
4 checks passed
@wouterbouvy wouterbouvy deleted the TalosRefinements branch February 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants