Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/core.105 check.pod.statuses #27

Merged
merged 11 commits into from
Mar 16, 2020

Conversation

aleksandrmelnikov
Copy link
Contributor

@aleksandrmelnikov aleksandrmelnikov commented Mar 16, 2020

@rushtehrani
Copy link
Contributor

I'm getting No resources in kube-logging, even though that's not required.

@aleksandrmelnikov
Copy link
Contributor Author

@rushtehrani I'm conflicted on this.
If they include optional components, we want to check if they have running pods right?
But if they don't include the optional component, we report nothing then?

@rushtehrani
Copy link
Contributor

@rushtehrani I'm conflicted on this.
If they include optional components, we want to check if they have running pods right?
But if they don't include the optional component, we report nothing then?

I think for this release, we'll just have to not check optional components. I even removed the message I mentioned earlier. The only optional component currently is kube-logging and that one is easy to check for someone that is familiar with Kubernetes.

@aleksandrmelnikov
Copy link
Contributor Author

@rushtehrani I'm conflicted on this.
If they include optional components, we want to check if they have running pods right?
But if they don't include the optional component, we report nothing then?

I think for this release, we'll just have to not check optional components. I even removed the message I mentioned earlier. The only optional component currently is kube-logging and that one is easy to check for someone that is familiar with Kubernetes.

Okay on this release reasoning.
To confirm, cert-manager is not optional?

@rushtehrani rushtehrani marked this pull request as ready for review March 16, 2020 23:13
@rushtehrani rushtehrani merged commit 2bb2b55 into master Mar 16, 2020
@rushtehrani rushtehrani deleted the feature/core.105-check.pod.statuses branch March 16, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants