Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show password icon button (sign up) #91 #125

Closed
wants to merge 2 commits into from

Conversation

AbedrahmanYassen
Copy link
Contributor

@AbedrahmanYassen AbedrahmanYassen commented Jul 27, 2023

PART OF GTC OPEN SOURCE INTIATIVE

Summary: This PR solves the issue that when you click on either of password and confirm-password show password icon both of are being shown

Related Issue: [ 91 ]

Proposed Changes

Description: [ I just separated the shared Boolean variable into two boolean variables for the password and show password , and the method that is handling the toggling ]

Checklist

Please review and check the following items before submitting your pull request:

  • I have executed the command flutter pub run build_runner build to generate the necessary auto routes files.
  • [ /] I have verified that the auto route generation did not introduce any errors or warnings.
  • [/] I have tested the changes locally and they are functioning as expected.
  • [/] My code follows the project's coding style and guidelines.
  • All existing and new tests are passing.
  • I have added necessary documentation or updated existing documentation (if applicable).
  • I have added appropriate unit tests or updated existing tests (if applicable).
  • [/] My commits are descriptive and follow the project's commit message conventions.
  • I have rebased my branch on the latest main branch.

Screenshots (if applicable)

After:
image

@salahamassi
Copy link
Member

Thanks for your contribution

we plan to use bond form for register page and login page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants