show password icon button (sign up) #91 #125
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PART OF GTC OPEN SOURCE INTIATIVE
Summary: This PR solves the issue that when you click on either of password and confirm-password show password icon both of are being shown
Related Issue: [ 91 ]
Proposed Changes
Description: [ I just separated the shared Boolean variable into two boolean variables for the password and show password , and the method that is handling the toggling ]
Checklist
Please review and check the following items before submitting your pull request:
flutter pub run build_runner build
to generate the necessary auto routes files.main
branch.Screenshots (if applicable)
After: