Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design pull-down third level menus for teachers page #8

Closed
4 tasks done
onewaypath opened this issue May 7, 2022 · 5 comments
Closed
4 tasks done

Design pull-down third level menus for teachers page #8

onewaypath opened this issue May 7, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@onewaypath
Copy link
Owner

onewaypath commented May 7, 2022

  • Ensure you are working on the latest version of dev1 branch

  • There are two sub-items for the teachers page. Thinking of mobile, we need a way to show this to the user from the submenu. One approach is to ad a pull-down option to the teachers item on the sub-menu. However, when the user pulls down it will cover the text below. Therefore, I think the pull down selection needs to shift the all the text on the screen down and then display the options to with left align. Please design this and add the feature to all the submenu on all pages. The structure of the teachers menu should be as follows:

  • Teachers
    - Spiritual Leaders (links to spiritual-leaders.html)
    - Resident Teachers (links to teachers.html)

  • On desktop, you can just install a simple pull down option

  • Push your changes back to the dev1 branch with a commit for this issue only

@dynamicdreamz1
Copy link
Collaborator

Design pull-down third level menus for teachers page => Done and updated

@onewaypath
Copy link
Owner Author

onewaypath commented May 10, 2022

It doesn't work on mobile.

  • Update to latest version of dev1 branch
  • Ensure page shifts down to reveal menu
  • Make sure you test on mobile before committing and pushing your changes.

image

image

@dynamicdreamz1
Copy link
Collaborator

This is done we have chack in sfari and ios.

@onewaypath
Copy link
Owner Author

onewaypath commented May 11, 2022

Now you are covering the page text.

  • Please shift page text down when drop down selected on mobile

image

@dynamicdreamz1
Copy link
Collaborator

This is done => 74f64ef

onewaypath added a commit that referenced this issue May 14, 2022
onewaypath added a commit that referenced this issue May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants
@dynamicdreamz1 @onewaypath @virat-benzatine and others