Replace SipHash (2 levels) with CircleHash (1 level) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is faster and allows 3 levels (192-bits) of BLAKE3.
ramtinms
approved these changes
Sep 29, 2021
turbolent
approved these changes
Sep 29, 2021
Comment on lines
+134
to
+135
| case 1, 2, 3: | ||
| if bd.blake3Hash == emptyBlake3Hash { |
There was a problem hiding this comment.
So the "fallback" is always Blake?
There was a problem hiding this comment.
fallback is blake3 (which should prevent the hash flooding) and the final fallback is just a list of values sorted by insertion time.
This was
linked to
issues
Sep 29, 2021
This was referenced Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster and allows 3 levels (192-bits) of BLAKE3 using only 4 levels total.