Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm package for the docgen-tool #1008

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Add npm package for the docgen-tool #1008

merged 5 commits into from
Jun 15, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 15, 2021

Description

Bundle the docgen-tool WASM as an NPM package.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Jun 15, 2021
@SupunS SupunS requested a review from turbolent as a code owner June 15, 2021 10:27
@SupunS SupunS mentioned this pull request Jun 15, 2021
6 tasks
@SupunS SupunS added the Feature label Jun 15, 2021
@SupunS SupunS force-pushed the supun/docgen-npm branch 2 times, most recently from 4dcc16b to 80357f9 Compare June 15, 2021 10:50
Base automatically changed from supun/docgen-wasm to master June 15, 2021 16:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #1008 (e60345b) into master (d2fc5d7) will not change coverage.
The diff coverage is n/a.

❗ Current head e60345b differs from pull request most recent head 87a317b. Consider uploading reports for the commit 87a317b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         267      267           
  Lines       32885    32885           
=======================================
  Hits        24856    24856           
  Misses       6908     6908           
  Partials     1121     1121           
Flag Coverage Δ
unittests 75.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fc5d7...87a317b. Read the comment docs.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Great this comes with a test 👍 Once merged we can publish it 🙁

Just one minor ask: Could you please add the package.json here https://github.com/onflow/cadence/blob/master/Makefile#L77? This way we can keep it updated

@turbolent turbolent merged commit 81729d2 into master Jun 15, 2021
@turbolent turbolent deleted the supun/docgen-npm branch June 15, 2021 22:34
@SupunS SupunS mentioned this pull request Jul 9, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants