Interpreting for basic attachment operations #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low/cadence into sainati/attachment-declaration-interpreting
…low/cadence into sainati/attachment-declaration-interpreting
dsainati1
commented
Nov 1, 2022
robert-e-davidson3
approved these changes
Nov 2, 2022
…low/cadence into sainati/attachment-declaration-interpreting
dsainati1
commented
Nov 3, 2022
runtime/interpreter/value.go
Outdated
Comment on lines
15221
to
15222
| interpreter.SharedState.inAttachmentIteration[v] = struct{}{} | ||
| defer delete(interpreter.SharedState.inAttachmentIteration, v) |
There was a problem hiding this comment.
Every time we enter an iteration over a composite's attachment we store that composite in this set, and remove it when we're done. This can't just be a bool like the storage iteration because we only want to restrict mutations of this specific composite's attachments, not all attachments generally.
…low/cadence into sainati/attachment-declaration-interpreting
…low/cadence into sainati/attachment-declaration-interpreting
…low/cadence into sainati/attachment-declaration-interpreting
SupunS
approved these changes
Nov 29, 2022
…low/cadence into sainati/attachment-declaration-interpreting
turbolent
reviewed
Dec 3, 2022
turbolent
reviewed
Dec 3, 2022
…low/cadence into sainati/attachment-declaration-interpreting
Base automatically changed from
sainati/attachments-check-add-remove
to
feature/attachments
December 12, 2022 15:21
|
CI is broken because of the automatic base branch change (GitHub bug), merging master should fix it and retrigger CI |
…sainati/attachment-declaration-interpreting
Codecov Report
@@ Coverage Diff @@
## feature/attachments #2113 +/- ##
=======================================================
+ Coverage 77.75% 77.87% +0.12%
=======================================================
Files 312 313 +1
Lines 66251 66529 +278
=======================================================
+ Hits 51513 51811 +298
+ Misses 12948 12924 -24
- Partials 1790 1794 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
turbolent
reviewed
Dec 12, 2022
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/attachments commit 3abda1a Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #357 and #2062
This implements runtime semantics for attaching, accessing and removing attachments
masterbranchFiles changedin the Github PR explorer