Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid taking references of transaction roles #2268

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 24, 2023

Work towards #2177

Description

As suggested in #2257 (comment), given that transaction roles are not first-class values, we should also forbid taking references to them.

Maybe we should also do this for other non-movable value types, like transactions, in Stable Cadence?


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

Yeah, it makes sense to extend this for transactions too.

Base automatically changed from bastian/extended-transaction-format-4 to feature/extended-transaction-format January 31, 2023 17:52
@turbolent
Copy link
Member Author

@dsainati1 Could you please have a look?

@turbolent turbolent merged commit f6f0fc3 into feature/extended-transaction-format Jan 31, 2023
@turbolent turbolent deleted the bastian/extended-transaction-format-5 branch January 31, 2023 18:04
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/extended-transaction-format commit fa4cf3d
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants