Use atree readonly iterators when mutation of values is not needed #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxamacker
added
Improvement
Performance
E&V Team
dsainati1
approved these changes
Mar 29, 2024
SupunS
approved these changes
Mar 29, 2024
turbolent
reviewed
Mar 29, 2024
Currently, we are not sure if all uses can be guaranteed to be readonly in two functions, so this commit uses atree non-readonly iterators in: - CompositeValue.ForEachFieldName - DictionaryValue.IterateKeys Also added TODO to determine if all uses can be guaranteed to be readonly for these, which would allow us to revert this change.
fxamacker
force-pushed
the
fxamacker/use-atree-readonly-iterators
branch
from
8edcf7e
to
b68900d
Compare
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2836
Atree readonly iterators are more performant than non-readonly iterators. This PR uses readonly iterators when feasible to prevent performance regression.
masterbranchFiles changedin the Github PR explorer