Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizer versioning fix #1785

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Normalizer versioning fix #1785

merged 6 commits into from
Oct 31, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 3, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: cdc39e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@onflow/fcl Patch
@onflow/fcl-wc Patch
@onflow/sdk Patch
@onflow/transport-grpc Patch
@onflow/transport-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink marked this pull request as ready for review October 4, 2023 01:01
@jribbink jribbink requested a review from a team as a code owner October 4, 2023 01:01
@jribbink
Copy link
Contributor Author

jribbink commented Oct 6, 2023

@JeffreyDoyle I broke the @onflow/util-semver package out. I think it's worth doing instead of using NPM semver package because the latter would have blown up our bundle size.

I'll update FCL Discovery once we release.

@jribbink
Copy link
Contributor Author

Just noting here I haven't merged this yet as I want to do some extra manual tests before releasing this. I want to try to spin up some versioned services in the dev wallet just to double check everything works as intended.

@jribbink jribbink merged commit a3143a8 into master Oct 31, 2023
1 check passed
@jribbink jribbink deleted the jribbink/fix-vsn-filtering branch October 31, 2023 18:18
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants