Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gas Limit Default #374

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Add Gas Limit Default #374

merged 2 commits into from
Aug 30, 2021

Conversation

sideninja
Copy link
Contributor

Closes #373

Description

Gas limit is now required and CLI is fixed to pass default max value.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #374 (a1f3bb3) into master (5ea9616) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   54.80%   54.74%   -0.06%     
==========================================
  Files          36       36              
  Lines        1872     1874       +2     
==========================================
  Hits         1026     1026              
- Misses        718      720       +2     
  Partials      128      128              
Flag Coverage Δ
unittests 54.74% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flowkit/transaction.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea9616...a1f3bb3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas Limit Error When Deploying To Testnet
3 participants