Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fvm meter/programs usage #229

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Update fvm meter/programs usage #229

merged 1 commit into from
Nov 1, 2022

Conversation

pattyshack
Copy link
Contributor

@pattyshack pattyshack commented Oct 31, 2022 •
edited
Loading

Closes #???

Description

  1. The canonical set of meter constants have been moved into the environment package
  2. Blocks also got moved into the environment package
  3. programs.Programs is deprecated

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@pattyshack pattyshack changed the title Update fvm meter constant import path Update fvm meter/programs usage Oct 31, 2022
@pattyshack
Copy link
Contributor Author

cc @Tonix517 since you'll probably need to do similar updates after your perfetching changes

@pattyshack pattyshack added the Improvement Technical work without new features, refactoring, improving tests label Nov 1, 2022
@pattyshack pattyshack merged commit a3a333f into master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@sideninja sideninja Awaiting requested review from sideninja

@psiemens psiemens Awaiting requested review from psiemens

@turbolent turbolent Awaiting requested review from turbolent

Assignees
No one assigned
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattyshack @janezpodhostnik