Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TokenForwarder and Switchboard target capabilities retrievable with test suite #125

Closed
wants to merge 3 commits into from

Conversation

satyamakgec
Copy link
Contributor

Close: #119

@joshuahannan
Copy link
Member

joshuahannan commented Mar 9, 2023

lets try to get some more reviews on this. Can we share with the community?

@joshuahannan joshuahannan marked this pull request as ready for review March 21, 2023 18:26
@joshuahannan
Copy link
Member

joshuahannan commented Mar 21, 2023

@satyamakgec I tried to update this branch with the latest from master, but I messed up resolving the conflicts in one of the js tests. Can you take a look and get the tests passing here? I'd like to merge this and move toward upgrading if possible. Thank you! 🙏

satyamakgec added a commit that referenced this pull request Mar 22, 2023
@satyamakgec
Copy link
Contributor Author

satyamakgec commented Mar 22, 2023

@satyamakgec I tried to update this branch with the latest from master, but I messed up resolving the conflicts in one of the js tests. Can you take a look and get the tests passing here? I'd like to merge this and move toward upgrading if possible. Thank you! 🙏

I have created the new PR i.e #130, Somehow neither rebasing or merging is working in this PR.

@joshuahannan joshuahannan deleted the forward-checker-austin branch March 22, 2023 15:19
joshuahannan pushed a commit that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TokenForwarder and Switchboard target capabilities retrievable
2 participants