Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ledger] Ledger cleanups + make a test async #1073

Merged
merged 7 commits into from
Aug 6, 2021
Merged

[ledger] Ledger cleanups + make a test async #1073

merged 7 commits into from
Aug 6, 2021

Commits on Aug 6, 2021

  1. Remove needless byte conversions

    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    0c1e83f View commit details
    Browse the repository at this point in the history

  2. Remove unused GetDefaultHashes 

    superseded by defaultHashes at init
    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    cf5bf8a View commit details
    Browse the repository at this point in the history

  3. Remove 2x unused functions in testutils

    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    ec1d12d View commit details
    Browse the repository at this point in the history

  4. Refactor the Compactor's start / stop cycle to LifecycleManager

    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    7030f31 View commit details
    Browse the repository at this point in the history

  5. Introduces a minimalistic Observer / Observable interface 

    See //reactivex.io/documentation/observable.html
    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    299f3bb View commit details
    Browse the repository at this point in the history

  6. Remove time-dependency (and flakiness) on the compactor test 

    - introduces a most minima form of the Observable interface to modules/observable
  See: http://reactivex.io/documentation/observable.html
- make the compactor test asynchronous
    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    e5e6435 View commit details
    Browse the repository at this point in the history

  7. Clean up after the simplification of decodeValue

    @huitseeker
    huitseeker committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    cc95354 View commit details
    Browse the repository at this point in the history