refactor transaction invoker normal execution path out of Process #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattyshack
commented
Oct 11, 2022
| common.TransactionLocation(proc.ID)) | ||
|
|
||
| // This will be used to charge fees. | ||
| computationUsed = env.ComputationUsed() |
There was a problem hiding this comment.
note that i've also move these two line to up, before checking for execution error, since we need the computationUsed for fees deduction on the error path.
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 4cd3c83 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Tonix517
approved these changes
Oct 12, 2022
janezpodhostnik
approved these changes
Oct 13, 2022
Comment on lines
+224
to
+226
| if !env.Logger().Debug().Enabled() { | ||
| return | ||
| } |
There was a problem hiding this comment.
Much better, thanks!
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 13, 2022
3366: refactor transaction invoker normal execution path out of Process r=pattyshack a=pattyshack I've made a few cosmetic changes to logExecutionIntensities, and switch fees deduction and storage check to use RunWithAllLimitsDisabled, but everything is basically identical to the original version. 3370: Avoid oppressive terminology r=turbolent a=turbolent See e.g. https://datatracker.ietf.org/doc/draft-knodel-terminology/ 3381: [Integration] Upgrading flow-emulator to v0.38.1 r=Tonix517 a=Tonix517 https://github.com/onflow/flow-emulator/releases/tag/v0.38.1 **Test** - [X] `make test` - [X] build and run load test to localnet Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com> Co-authored-by: Bastian Müller <bastian@axiomzen.co> Co-authored-by: Tony Z <tony.zhang@dapperlabs.com>
|
Build failed (retrying...): |
I've made a few cosmetic changes to logExecutionIntensities, and switch fees deduction and storage check to use RunWithAllLimitsDisabled, but everything is basically identical to the original version.
pattyshack
force-pushed
the
patrick/refactor-normal-execution
branch
from
f24682b
to
beb1ab2
Compare
|
Canceled. |
|
bors merge |
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
==========================================
- Coverage 55.00% 54.38% -0.62%
==========================================
Files 734 663 -71
Lines 67341 60400 -6941
==========================================
- Hits 37040 32850 -4190
+ Misses 27264 24902 -2362
+ Partials 3037 2648 -389
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few cosmetic changes to logExecutionIntensities, and switch fees deduction and storage check to use RunWithAllLimitsDisabled, but everything is basically identical to the original version.