log num txs and state changed in block executed log #4683
Conversation
zhangchiqing
requested review from
koko1123,
fxamacker,
janezpodhostnik and
sideninja
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 6c10061 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4683 +/- ##
==========================================
- Coverage 54.89% 54.88% -0.01%
==========================================
Files 916 916
Lines 85421 85429 +8
==========================================
- Hits 46894 46891 -3
- Misses 34930 34947 +17
+ Partials 3597 3591 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
engine/execution/ingestion/engine.go
Outdated
| @@ -717,6 +719,14 @@ func (e *Engine) executeBlock( | |||
|
|
|||
| } | |||
|
|
|||
| func transactionCount(result flow.ExecutionResult) uint64 { | |||
There was a problem hiding this comment.
Will this include the system transaction?
There was a problem hiding this comment.
it does not, so this only report the user transaction (non-system transactions). system transaction is always a fixed single transaction, so I don't think we need to +1.
There was a problem hiding this comment.
should it be called nonSystemTransactionCount then ?
engine/execution/ingestion/engine.go
Outdated
| @@ -717,6 +719,14 @@ func (e *Engine) executeBlock( | |||
|
|
|||
| } | |||
|
|
|||
| func transactionCount(result flow.ExecutionResult) uint64 { | |||
There was a problem hiding this comment.
should it be called nonSystemTransactionCount then ?
No description provided.