Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more parts of the migration deterministic #5979

Merged
merged 1 commit into from
May 24, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented May 24, 2024

Work towards onflow/cadence#3366

@turbolent turbolent requested review from a team May 24, 2024 19:47
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.83%. Comparing base (e68a199) to head (932b678).

Files Patch % Lines
cmd/util/ledger/util/registers/registers.go 0.00% 6 Missing ⚠️
...til/ledger/migrations/fix_broken_data_migration.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5979   +/-   ##
=======================================
  Coverage   55.82%   55.83%           
=======================================
  Files        1129     1129           
  Lines       89214    89260   +46     
=======================================
+ Hits        49806    49840   +34     
- Misses      34654    34660    +6     
- Partials     4754     4760    +6     
Flag Coverage Δ
unittests 55.83% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent added this pull request to the merge queue May 24, 2024
Merged via the queue into master with commit d3680b8 May 24, 2024
55 checks passed
@turbolent turbolent deleted the bastian/improve-migration-determinism branch May 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants