Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] adding a new encoding type for captured precompiled calls #6488

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Sep 20, 2024

Since we have state change checksum going forward, there is no need to check the input of the captured precompiled calls. Currently emitting inputs as part of captured precompiled calls is costly and removing this unnecessary data part can reduce an EVM transaction cost (especially for COA proofs).

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.49%. Comparing base (56ac820) to head (4387e74).

Files with missing lines Patch % Lines
fvm/evm/types/precompiled.go 85.18% 3 Missing and 1 partial ⚠️
fvm/evm/testutils/misc.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6488      +/-   ##
==========================================
+ Coverage   41.48%   41.49%   +0.01%     
==========================================
  Files        2027     2027              
  Lines      144784   144797      +13     
==========================================
+ Hits        60060    60083      +23     
+ Misses      78513    78509       -4     
+ Partials     6211     6205       -6     
Flag Coverage Δ
unittests 41.49% <80.64%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms marked this pull request as ready for review September 20, 2024 22:45
@ramtinms ramtinms added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 901e171 Sep 27, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-optimize-precompiled-call-tracking branch September 27, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants