Adds getIDs() to NFT program recovery

[joshuahannan]

Closes #6450

Adds an implementation of NonFungibleToken.Collection.getIDs() to the recovered program for unmigrated NFT contracts.

This will allow projects that didn't migrate to be able to query broken collections and recreate ownership with a newly deployed contract.

[joshuahannan]

Are there any other changes I need to make for this? I couldn't see if there were tests anywhere for this that I needed to update.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.26%. Comparing base (21cfe5a) to head (76678dc).
Report is 392 commits behind head on master.

Files with missing lines	Patch %	Lines
fvm/environment/program_recovery.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6513      +/-   ##
==========================================
- Coverage   41.28%   41.26%   -0.02%     
==========================================
  Files        2030     2030              
  Lines      145865   145868       +3     
==========================================
- Hits        60221    60197      -24     
- Misses      79419    79446      +27     
  Partials     6225     6225              

Flag	Coverage Δ
unittests	41.26% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[janezpodhostnik]

I don't think there are any tests testing this specifically. This looks like the only location that needs to change.

Someone from @onflow/cadence should take a look as well.

Deploying this requires an HCU.

[joshuahannan]

Do we have an HCU planned for the near future that we can slot this into? There is no rush, but it would be nice to get it in relatively soon because some developers whose contracts broke are asking for it

[turbolent]

Yes, there's an HCU planned. Please connect with @Kay-Zee @vishalchangrani

[turbolent]

Looks good! Can you please add a test?

[joshuahannan]

@turbolent Where are the tests for this?

[turbolent]

@turbolent Where are the tests for this?

At the moment there is only TestContractCheckingMigrationProgramRecovery in the Cadence 1.0 migration code, which only tests FT AFAICS. There are no tests in FVM yet and it would be great to add some. Maybe @onflow/flow-cadence-execution can help with that

[joshuahannan]

Yeah, I wouldn't know where to start with that so I could definitely use some help