-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License View with medias #173
Conversation
92efb58
to
555e549
Compare
I feel good about this view for now. We just need a couple more things before we can merge this and announce the deployment.
Then we need to get a few approvals on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really exciting to see this coming along! Also really dig the creational pattern.
contracts/ExampleNFT.cdc
Outdated
@@ -159,7 +160,8 @@ pub contract ExampleNFT: NonFungibleToken, ViewResolver { | |||
traitsView.addTrait(fooTrait) | |||
|
|||
return traitsView | |||
|
|||
// case Type<MetadataViews.NFTLicense>(): | |||
// return nil //MetadataViews.NFTLicense() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know the license we'll use for this example contract? As long as things are commented, it would be nice to demo the intended use of the helper methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to include the nlp util view. I had it commented out because I was seeing a bug with the cadence testing framework
This was mistakenly merged. I reverted this in a different PR and I'm going to open a new PR with these changes so we can continue to get reviews and add docs |
I opened a new PR with the same changes. Everyone who has approved already please add their approval to that PR and we'll work on getting the docs updated and getting more eyes on the PR. |
Description
Builds on the view proposed in #172 that is based on the Flow NFT License Project.
Includes Media links for a badge and a description.
The specific IPFS format, link type, and locations for the links are going to be delayed for now so we can get the basic licenses and their descriptions on chain.
I also removed the JS tests because they were causing issues. We're gonna try to use the Cadence testing framework here from now on.
For contributor use:
master
branchFiles changed
in the Github PR explorer