Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code submission for FLIP fest 'Playground: Fix client-side errors in the playground frontend #58' - Milestone 0.5 #167

Closed
wants to merge 2 commits into from

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 8, 2021

Closes: #163 #164 #165 #166

Description

The Examples.tsx component had unnecessarily been including a 'key' prop in components nested inside of the main component that was being created by the map function. I believe one 'key' prop applied to the main component is sufficient.

The series of Redirects from reach router used in the project provider caused a cascade of errors as described in the four bug issues that I submitted. I'm currently investigating how this can be optimized. For now, the use of 'noThrow' in reach router suppresses the errors in the console. As explained in the reach router docs for the 'Redirect' feature:

"""
Redirect works with componentDidCatch to prevent the tree from rendering and starts over with a new location.

Because React doesn’t swallow the error this might bother you. For example, a redirect will trigger Create React App’s error overlay. In production, everything is fine. If it bothers you, add noThrow and Redirect will do redirect without using componentDidCatch.

If you’re using React < 16 Redirect will not throw at all, regardless of what value you put for this prop.
"""


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • [n/a] Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • [n/a] Added appropriate labels

@vercel
Copy link

vercel bot commented Oct 8, 2021

@hichana is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

@hichana hichana changed the title Browser console bug fixes for flip-fest issue "Playground: Fix client-side errors in the playground frontend #58" Code submission for FLIP fest 'Playground: Fix client-side errors in the playground frontend #58' - Milestone 0.5 Oct 24, 2021
@kerrywei kerrywei linked an issue Dec 16, 2021 that may be closed by this pull request
@sideninja
Copy link
Contributor

@MrDSGC @alse can you look into this if it's still relevant to our current work?

@alse alse changed the base branch from master to staging September 8, 2022 20:02
Copy link
Contributor

@alse alse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-targeted this to the staging branch. It looks good, but needs a rebase to resolve conflicts

@alse alse changed the base branch from staging to master September 8, 2022 20:06
@sideninja sideninja closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Keys error throws in browser console A 'uncaught' warning the the browser console
3 participants