Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow-js-testing handlebars templates to @onflow-flow-js-testing@0.3.0-alpha.14 #275

Closed
wants to merge 2 commits into from

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jul 21, 2022

Closes: #276

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flow-playground ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 11:49PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 21, 2022 22:55 Inactive
@jribbink jribbink linked an issue Jul 21, 2022 that may be closed by this pull request
@jribbink jribbink marked this pull request as draft July 21, 2022 22:59
@jribbink jribbink changed the title Update flow-js-testing template Update flow-js-testing handlebars templates Jul 22, 2022
@jribbink jribbink added dependencies Pull requests that update a dependency file Improvement labels Jul 22, 2022
@vercel vercel bot temporarily deployed to Preview July 22, 2022 18:10 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2022 22:04 Inactive
@jribbink jribbink marked this pull request as ready for review August 23, 2022 23:58
@vercel vercel bot temporarily deployed to Preview August 23, 2022 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2022 00:02 Inactive
@jribbink jribbink changed the title Update flow-js-testing handlebars templates Update flow-js-testing handlebars templates to @onflow-flow-js-testing@0.3.0-alpha.14 Aug 24, 2022
@jribbink jribbink requested a review from MrDSGC August 24, 2022 00:28
@jribbink jribbink assigned alse and unassigned alse Aug 24, 2022
@jribbink jribbink requested a review from alse August 24, 2022 00:28
@vercel vercel bot temporarily deployed to Preview August 24, 2022 00:30 Inactive
@sideninja
Copy link
Contributor

@alse @MrDSGC please take a look into this one if it's still relevant

@alse
Copy link
Contributor

alse commented Sep 8, 2022

@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20

Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1)
  18 |             code,
  19 |             
> 20 |         });
     |           ^
  21 |     )
  22 | 
  23 |     // Add your expectations here
    at t (parser-babel.js?6103:1:1)
    at Object.eval [as parse] (parser-babel.js?6103:1:1)
    at Object.parse (standalone.js?325b:15:1)
    at ts (standalone.js?325b:15:1)
    at us (standalone.js?325b:15:1)
    at eval (standalone.js?325b:55:1)
    at Object.format (standalone.js?325b:55:1)
    at prettify (generator.ts?e988:18:1)
    at generateScriptUnitTest (generator.ts?e988:251:1)
    at eval (generator.ts?e988:288:1)
    ```

@jribbink
Copy link
Contributor Author

jribbink commented Sep 9, 2022

@jribbink I'm seeing this error when exporting a project. It's not happening on the staging branch. src/templates/js/scriptUnitTest.hbs:20

Uncaught (in promise) SyntaxError: Unexpected token, expected "," (20:11) (at parser-babel.js?6103:1:1)
  18 |             code,
  19 |             
> 20 |         });
     |           ^
  21 |     )
  22 | 
  23 |     // Add your expectations here
    at t (parser-babel.js?6103:1:1)
    at Object.eval [as parse] (parser-babel.js?6103:1:1)
    at Object.parse (standalone.js?325b:15:1)
    at ts (standalone.js?325b:15:1)
    at us (standalone.js?325b:15:1)
    at eval (standalone.js?325b:55:1)
    at Object.format (standalone.js?325b:55:1)
    at prettify (generator.ts?e988:18:1)
    at generateScriptUnitTest (generator.ts?e988:251:1)
    at eval (generator.ts?e988:288:1)
    ```

Apologies, that should be fixed now.

@vercel vercel bot temporarily deployed to Preview September 9, 2022 23:49 Inactive
@alse
Copy link
Contributor

alse commented Sep 15, 2022

Thanks @jribbink , that fixed it. I followed the readme instructions to run the generated tests and I'm 6 were failing. Are they passing for you?

"execution error code 1006: [Error Code: 1006] invalid proposal key: public key 0 on account [...] does not have a valid signature: [Error Code: 1009] invalid envelope key: public key 0 on account [...] does not have a valid signature: signature is not valid"

flow cli version v0.39.3

@bthaile
Copy link
Contributor

bthaile commented Nov 14, 2022

closing, will need to reevaluate after polish sprint and mvp testing

@bthaile bthaile closed this Nov 14, 2022
@bthaile bthaile deleted the jribbink/update-js-testing branch May 16, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update flow-js-testing to @onflow/flow-js-testing@0.3.0-alpha.14
4 participants