Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitted subscribe blocks, headers and block digests rpc calls #1437

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Splitted subscribe blocks, headers and block digests rpc calls #1437

merged 4 commits into from
Mar 5, 2024

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Mar 4, 2024 •
edited
Loading

Connected with onflow/flow-go#5307

Context

Splitted subscribe rpc calls into 3 separate to make the client code simpler.

SubscribeBlocks into:

  • SubscribeBlocksFromStartBlockID
  • SubscribeBlocksFromStartHeight
  • SubscribeBlocksFromLatest

SubscribeBlockHeaders into:

  • SubscribeBlockHeadersFromStartBlockID
  • SubscribeBlockHeadersFromStartHeight
  • SubscribeBlockHeadersFromLatest

SubscribeBlockDigests into:

  • SubscribeBlockDigestsFromStartBlockID
  • SubscribeBlockDigestsFromStartHeight
  • SubscribeBlockDigestsFromLatest

@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this pull request Mar 4, 2024
Merged
@durkmurder durkmurder merged commit 8efb057 into onflow:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UlyanaAndrukhiv @peterargue @durkmurder