Contract deployment args fix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign,
bjartek and
ianthpun
as code owners
ianthpun
approved these changes
May 3, 2024
ianthpun
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves onflow/flow-cli#1352 & onflow/flow-cli#1427
Mostly a backport of the changes made in dc655f4...a1765cd on the
stable-cadencebranch.Forced changes that were necessary to update to latest Cadence version unintentionally fixed this issue
That being said, it uses the
Preparefunction instead of marshalling and unmarshalling as a hack to convert structs tomap[string]anywhich is a better/simpler way to fix this. Because the JSON values from Cadence are structs, we cannot conform tomap[string]any, so I relaxed the deployment arg type toany