Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for private key to be created in a target directory #48

Merged
merged 6 commits into from
May 14, 2024

Conversation

chasefleming
Copy link
Member

Closes: #47

@chasefleming
Copy link
Member Author

chasefleming commented May 8, 2024

@bjartek this is a minor breaking change. Will this be an issue upgrading for you? Alternative would be we could have the existing Init function and a new function called InitFromDirectory.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.81%. Comparing base (200347d) to head (32f9589).
Report is 1 commits behind head on main.

Files Patch % Lines
accounts/account.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   58.77%   58.81%   +0.03%     
==========================================
  Files          29       29              
  Lines        2193     2190       -3     
==========================================
- Hits         1289     1288       -1     
+ Misses        718      717       -1     
+ Partials      186      185       -1     
Flag Coverage Δ
unittests 58.81% <20.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjartek
Copy link
Collaborator

bjartek commented May 8, 2024

@bjartek this is a minor breaking change. Will this be an issue upgrading for you? Alternative would be we could have the existing Init function and a new function called InitFromDirectory.

Not an issue for me

@chasefleming chasefleming merged commit 2f09f4a into main May 14, 2024
2 checks passed
@chasefleming chasefleming deleted the chasefleming/init-path branch May 14, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Allow for private key to be created in a target directory
5 participants