feat: added ctx support to all methods that require it and fixed tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjartek
commented
Feb 5, 2024
flowkit.go
Outdated
| "github.com/onflow/flowkit/accounts" | ||
| "github.com/onflow/flowkit/config" | ||
| "github.com/onflow/flowkit/gateway" | ||
| "github.com/onflow/flowkit/output" | ||
| "github.com/onflow/flowkit/project" | ||
| "github.com/onflow/flowkit/transactions" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
dont know why this reorganization happends, i just run go mod tidy
ianthpun
reviewed
Feb 5, 2024
bjartek
commented
Feb 7, 2024
ianthpun
approved these changes
Feb 7, 2024
|
@bjartek Did you mean to target master? Changes to the feature branch should be related to it (Cadence 1.0) upgrades. |
|
I was told by Ian to target this branch since it breaks bc, but this feature would be very nice to have in v1 of flowkit aswell. Is the small breaking change to Ping ok, or should we just hardcode the context in Ping for now to not break bc? |
|
@turbolent i created an alternate pr #9 that targets master and do not break BC in the main Services interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4