Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accounts add or update #54

Merged
merged 3 commits into from
May 30, 2024

Conversation

bartolomej
Copy link
Contributor

Resolve #53

@chasefleming
Copy link
Member

Thanks for grabbing this one @bartolomej !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.81%. Comparing base (2f09f4a) to head (8f37008).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   58.81%   58.81%           
=======================================
  Files          29       29           
  Lines        2190     2190           
=======================================
  Hits         1288     1288           
  Misses        717      717           
  Partials      185      185           
Flag Coverage Δ
unittests 58.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit 39af92e into onflow:main May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] accounts.AddOrUpdate doesn't update the existing account when passing a different struct instance
5 participants