Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Capabilities are not checked to be valid #63

Closed
Tracked by #59
sisyphusSmiling opened this issue Jun 12, 2023 · 0 comments · Fixed by #81
Closed
Tracked by #59

[BUG] Capabilities are not checked to be valid #63

sisyphusSmiling opened this issue Jun 12, 2023 · 0 comments · Fixed by #81
Assignees
@sisyphusSmiling
Labels
bug Something isn't working

Comments

@sisyphusSmiling
Copy link
Collaborator

Description

In several instances of the codebase, capabilities are not validated to be borrowable before storing them. The following code locations should have the capability validated:

Recommendation

We recommend validating the capabilities mentioned above.
@sisyphusSmiling sisyphusSmiling added the bug Something isn't working label Jun 12, 2023
@sisyphusSmiling sisyphusSmiling mentioned this issue Jun 12, 2023
Closed
15 tasks
@sisyphusSmiling sisyphusSmiling self-assigned this Jun 13, 2023
@sisyphusSmiling sisyphusSmiling mentioned this issue Jun 13, 2023
Merged
sisyphusSmiling added a commit that referenced this issue Jun 13, 2023
@sisyphusSmiling
add capability checks & test coverage in HybridCustody (#81)
57a047a 
Closes: #63

Added checks on Capability parameters throughout the HybridCustody
contract, along with test coverage for Manager init values. I realize
some of these checks are redundant (e.g. `HybridCustody.createManager()`
flowing through to `Manager.init()`), but helpful for readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisyphusSmiling sisyphusSmiling

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add capability checks & test coverage in HybridCustody onflow/hybrid-custody
1 participant
@sisyphusSmiling