-
Notifications
You must be signed in to change notification settings - Fork 213
Conversation
- Move all files in `contracts`, `transactions` and `scripts` directories - Use relative file imports in all files (instead of placeholders) - Clean up comments - Remove unused/broken scripts or transactions
3a63df6
to
fbd35a2
Compare
Is there a plan to include the templates or contracts package? One of the big reasons for structuring it like this was so that we could have packages for different languages that allow people get automatically construct templates from the application code with the correct import addresses with a import and a single method call. Is that still possible here? |
@@ -0,0 +1,199 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we import this from the Flow fungible token repo instead of copying it here?
@@ -1,4 +1,4 @@ | |||
import FungibleToken from 0xFUNGIBLETOKENADDRESS | |||
import FungibleToken from "./FungibleToken.cdc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if we could find a way to import contract interfaces without having to copy and paste them to the same repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed. I left my thoughts here, but I think we could make this work with URL imports: onflow/flow-cli#71 (comment)
Yep I think this is still possible. This repo didn't have those packages to begin with, but I hope to add them in. The main change now is the fact that the placeholders (e.g. |
Ok, will merge this for now. |
Add item page and style profile pages
This PR restructures
kitty-items-cadence
to be more along the lines of @joshuahannan's proposal here: https://forum.onflow.org/t/typical-dapp-project-structure/814/4?u=peteThis restructure also switches to using filename imports for contracts (instead of placeholders) in preparation for us to integrate the new
flow project
commands (cc @sideninja).