Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: group page minor fixes #421

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

aleeexgreeen
Copy link
Contributor

What this PR accomplishes

  • Removes table headers for screen reader only
  • Adds "dataset" text to number of datasets per group for screen readers only

Issue(s) addressed

  • DATA-1289

What needs review

  • aria-hidden="true" attributes on "Groups" and "Datasets" table headers
  • Screen reader only text of "dataset" or "datasets" for each number of datasets for each group

@KatiRG KatiRG added the 2.1.9 label Oct 5, 2023
@aimalkhan aimalkhan added 2.1.10 and removed 2.1.9 labels Oct 6, 2023
@aleeexgreeen aleeexgreeen changed the base branch from main to develop October 26, 2023 13:40
@KatiRG
Copy link
Collaborator

KatiRG commented Oct 30, 2023

  • aria-hidden="true" attributes on "Groups" and "Datasets" table headers
  • Screen reader only text of "dataset" or "datasets" ("jeu de données" / "jeux de données") for each number of datasets for each group

@KatiRG KatiRG merged commit c16edcd into develop Oct 30, 2023
@KatiRG KatiRG deleted the DATA-1289_group_page_minor_fixes branch October 30, 2023 14:30
sdpaul0 added a commit that referenced this pull request Nov 7, 2023
* release v2.1.9 (#429)

Release v2.1.9 includes the following features:
* Accessbility Fixes #414
* Help Page changes #417 
* Header Changes for Internal Data Catalogue #424
* Other UI fixes #423, #420, #419, #418, #415, #413, #412

* [Task]: Add description lists to About page content  (#422)

* Adds descriptions lists to French and English File types and Metadata sections

* Removes RSS box on dataset pages (#434)

* Removes RSS box from the Dataset page

* Removes supporting files when there are none (#435)

* Redesign the access level & AI callout boxes (#433)

* Callout redesign
* Remove heading when empty and reformatting

* WIP: removes table headers for sr only, adds sr dataset text for datasets (#421)

* [Task]: Remove truncation for the dataset & dataset resource names (#431)

* Removes truncation from dataset title and resource title
* button positioning on all screens
* margin on explore button and non breaking space in icon for edit
* typo fix

* Pagination colors and font weight changed (#432)

* Pagination Changes: the background color of the active page
* Pagination Changes: hyperlinks to DS link colour
* Pagination Changes: text to semi-bold

* [Task]: Adds 'datasets' to topic count on homepage (#426)

* Adds 'datasets' to topic count on homepage

* [Task]: Groups page should be aligned to the Ministries page (#437)

* Ministries' search page design change to match group page
* adds numeric column and hover state
* accessibility on group and ministry search page
* Adds count back into link title

* [Task]: Add aria labels to pagination (#436)

* Adds page.py to override Page class in CKAN core's pagination.py
* Adds necessary labels to each pagination link
* Changes next and previous page symbol to Ontario Design System single chevron
* Removes link tag from ... list items
* Adds aria-current role to current page.
* Translates all aria-labels

* [Fix]: group ministry search page interaction state (#438)

* Fixes interaction state colours

* release_v2.1.10 (#440)

Release v2.1.10 includes the following features:
*UI Changes on Groups, Ministries, Dataset and Resource pages #438 #437 #435 #434 #433 #431
*Pagination UX improvements #436 #432 (ed

---------

Co-authored-by: AleexGreen <alex.green@ontario.ca>
sdpaul0 added a commit that referenced this pull request Nov 22, 2023
* release v2.1.9 (#429)

Release v2.1.9 includes the following features:
* Accessbility Fixes #414
* Help Page changes #417 
* Header Changes for Internal Data Catalogue #424
* Other UI fixes #423, #420, #419, #418, #415, #413, #412

* [Task]: Add description lists to About page content  (#422)

* Adds descriptions lists to French and English File types and Metadata sections

* Removes RSS box on dataset pages (#434)

* Removes RSS box from the Dataset page

* Removes supporting files when there are none (#435)

* Redesign the access level & AI callout boxes (#433)

* Callout redesign
* Remove heading when empty and reformatting

* WIP: removes table headers for sr only, adds sr dataset text for datasets (#421)

* [Task]: Remove truncation for the dataset & dataset resource names (#431)

* Removes truncation from dataset title and resource title
* button positioning on all screens
* margin on explore button and non breaking space in icon for edit
* typo fix

* Pagination colors and font weight changed (#432)

* Pagination Changes: the background color of the active page
* Pagination Changes: hyperlinks to DS link colour
* Pagination Changes: text to semi-bold

* [Task]: Adds 'datasets' to topic count on homepage (#426)

* Adds 'datasets' to topic count on homepage

* [Task]: Groups page should be aligned to the Ministries page (#437)

* Ministries' search page design change to match group page
* adds numeric column and hover state
* accessibility on group and ministry search page
* Adds count back into link title

* [Task]: Add aria labels to pagination (#436)

* Adds page.py to override Page class in CKAN core's pagination.py
* Adds necessary labels to each pagination link
* Changes next and previous page symbol to Ontario Design System single chevron
* Removes link tag from ... list items
* Adds aria-current role to current page.
* Translates all aria-labels

* [Fix]: group ministry search page interaction state (#438)

* Fixes interaction state colours

* release_v2.1.10 (#440)

Release v2.1.10 includes the following features:
*UI Changes on Groups, Ministries, Dataset and Resource pages #438 #437 #435 #434 #433 #431
*Pagination UX improvements #436 #432 (ed

* [Fix]: Numeric column font styling (#439)

* removes numeric font styling

* [Task]: Align the font size & colour across the website (#442)

* Aligns font and text colour across website
* Search input field font size

* Aligns font and size of file type labels (#443)

* release_v2.1.11

---------

Co-authored-by: AleexGreen <alex.green@ontario.ca>
@aimalkhan aimalkhan mentioned this pull request Nov 23, 2023
aimalkhan added a commit that referenced this pull request Nov 23, 2023
Release v2.1.10 includes the following features:

* UI Changes on Groups, Ministries, Dataset and Resource pages #438 #437 #435 #434 #433 #431 #426 #422 #421
* Pagination UX improvements #436 #432
@aimalkhan aimalkhan mentioned this pull request Nov 23, 2023
aimalkhan added a commit that referenced this pull request Nov 23, 2023
Release v2.1.10 includes the following features:

* UI Changes on Groups, Ministries, Dataset and Resource pages #438 #437 #435 #434 #433 #431 #426 #422 #421
* Pagination UX improvements #436 #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants