[TASK]: Only display "Report an error" on Open datasets #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alexandra-Green is this PR dealing with just 1348? seems like there are commits from two different people in there. |
|
@aimalkhan it's because it's going into main instead of develop. Can we change the default for merges to go into develop? |
That will require changing the Default branch setting, which causes issues like the branch shown on front page or cloned by default to also change |
aleeexgreeen
suggested changes
Dec 11, 2023
…to DATA-1348 Edits made so Report an Error banner only appears when the dataset is Open.
Merged
aimalkhan
pushed a commit
that referenced
this pull request
Jan 5, 2024
Merged
sdpaul0
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Displays report an error form only when there are resources * <Should only show Report an Error message if the resource is Open> * Checks if both the resouce and package are Open to post the Report an Error banner * Changed the line so it checks the dataset's access level
sdpaul0
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR accomplishes
"Report an error with this data" banner only appears when the dataset is Open
Issue(s) addressed
DATA-1348
What needs review
If the dataset is Open, the banner is at the bottom of the page.
If the dataset is either Under Review or Restricted, the banner does not appear.