This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
Matt/collab/onfront 73 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-ods
reviewed
Jul 12, 2024
There was a problem hiding this comment.
LGTM. Checked all the cases mentioned in the acceptance criteria and everything is working as expected.
Some observations:
- In the CLI checkbox options, the
<a>and<i>key options are doing the same thing: toggling back and forth between select and unselect/deselect all. We can keep one key only and adjust the message. - Removing packages that are not installed:
If I try to remove packages that are not installed/uinstalled, the process should exit before giving the confirmation prompt. In my opinion, there is no need for that prompt if the packages don't exist, because even with the confirmation prompt, we'll be giving the same response/log messages after that extra step. - The
tabkey should also work in addition to the arrow keys while selecting the packages through the CLI.
Again, great work, and sorry for my nit-picky observations.
syed-ods
approved these changes
Jul 12, 2024
matt-stjean
approved these changes
Jul 15, 2024
- addPackage question now displays checkbox list of available packages to install - eslint and prettier config object keys renamed to reflect the @ongov package names - `isPackageInstalled()` now also checks for packages within `devDependencies` - `extractChildObjectValuesByKey()` util now has graceful failure and descriptive comments
… ontario-remove-package
- removed redundant `isOntarioProject` check from addPackage command - same check is found with `ontario-add-package` bin file - standardized debug messages across add and remove package commands
…instead exporting each question
kyle-binger-3
force-pushed
the
matt/collab/ONFRONT-73
branch
from
e94b77b
to
6f36ed1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements changes to the ontario-add-package and ontario-remove-package commands. Both now accept multiple package values (through a question prompt showing only our https://github.com/ongov packages) as their respective arguments.
Along with this, there are some other minor changes:
isPackageInstalled()now also checksdevDependencieswithin the generated project's package.jsoncheckAndRemoveConfigFiles()has been added and is in use during the execution ofontario-remove-package